Skip to content

feat(server): userSession model #9629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
fengmk2 wants to merge 2 commits into from
Closed

feat(server): userSession model #9629

fengmk2 wants to merge 2 commits into from

Conversation

@fengmk2
Copy link
Collaborator

@fengmk2 fengmk2 commented Jan 10, 2025 •
edited
Loading

No description provided.

@github-actions github-actions bot added app:server test Related to test cases labels Jan 10, 2025
@fengmk2 Graphite App
Copy link
Collaborator Author

fengmk2 commented Jan 10, 2025 •
edited
Loading

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@fengmk2 fengmk2 marked this pull request as ready for review January 10, 2025 07:33
@graphite-app graphite-app bot requested a review from Brooooooklyn January 10, 2025 07:33
@codecov
Copy link

codecov bot commented Jan 10, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 99.12281% with 1 line in your changes missing coverage. Please review.

Project coverage is 53.37%. Comparing base (289c925) to head (49fb942).
Report is 1 commits behind head on canary.

Files with missing lines Patch % Lines
packages/backend/server/src/models/user-session.ts 99.10% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           canary    #9629      +/-   ##
==========================================
+ Coverage   52.85%   53.37%   +0.51%     
==========================================
  Files        2180     1959     -221     
  Lines       98540    93492    -5048     
  Branches    16752    15882     -870     
==========================================
- Hits        52087    49899    -2188     
+ Misses      45007    41755    -3252     
- Partials     1446     1838     +392
Flag Coverage Δ
server-test 77.85% <99.12%> (+0.01%) ⬆️
unittest 31.24% <ø> (-1.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fengmk2 Graphite App
Copy link
Collaborator Author

fengmk2 commented Jan 10, 2025

user-session.spect.ts is not running

@fengmk2 fengmk2 force-pushed the 01-10-feat_server_usersession_model branch from 2acfdba to c17b78a Compare January 10, 2025 08:25
@fengmk2 fengmk2 mentioned this pull request Jan 10, 2025
Merged
@fengmk2 fengmk2 force-pushed the 01-10-feat_server_usersession_model branch from c17b78a to 868fbaa Compare January 10, 2025 08:51
@fengmk2 fengmk2 changed the base branch from canary to 01-10-test_server_should_await_throwsasync_assert January 10, 2025 08:51
@fengmk2 fengmk2 changed the base branch from 01-10-test_server_should_await_throwsasync_assert to graphite-base/9629 January 10, 2025 09:08
@fengmk2 fengmk2 force-pushed the graphite-base/9629 branch from 75a371c to 93c585a Compare January 10, 2025 09:24
@fengmk2 fengmk2 force-pushed the 01-10-feat_server_usersession_model branch from 868fbaa to 2ebeca6 Compare January 10, 2025 09:24
@fengmk2 fengmk2 changed the base branch from graphite-base/9629 to canary January 10, 2025 09:25
@fengmk2 fengmk2 force-pushed the 01-10-feat_server_usersession_model branch 2 times, most recently from 2d114ed to f8b9088 Compare January 10, 2025 10:11
Brooooooklyn
Brooooooklyn reviewed Jan 11, 2025
View reviewed changes
@fengmk2 fengmk2 force-pushed the 01-10-feat_server_usersession_model branch from f8b9088 to 49fb942 Compare January 11, 2025 14:17
fengmk2
fengmk2 commented Jan 11, 2025
View reviewed changes
@fengmk2 fengmk2 requested a review from Brooooooklyn January 12, 2025 02:37
@fengmk2 fengmk2 force-pushed the 01-10-feat_server_usersession_model branch from 49fb942 to 7571209 Compare January 13, 2025 02:47
@fengmk2 fengmk2 changed the base branch from canary to 01-13-feat_server_verificationtoken_model January 13, 2025 02:47
This was referenced Jan 13, 2025
Merged
Merged
Merged
Merged
@fengmk2 fengmk2 force-pushed the 01-10-feat_server_usersession_model branch from 7571209 to b6b0270 Compare January 13, 2025 04:57
@fengmk2 fengmk2 force-pushed the 01-13-feat_server_verificationtoken_model branch 2 times, most recently from 340d741 to db19a30 Compare January 13, 2025 09:12
@fengmk2 fengmk2 closed this Jan 13, 2025
@fengmk2 fengmk2 deleted the 01-10-feat_server_usersession_model branch January 13, 2025 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@darkskygit darkskygit Awaiting requested review from darkskygit

@forehalo forehalo Awaiting requested review from forehalo

@Brooooooklyn Brooooooklyn Awaiting requested review from Brooooooklyn

Assignees

No one assigned

Labels

app:server test Related to test cases

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fengmk2 @Brooooooklyn